Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm is not ICollection<Peer> anymore #326

Merged
merged 4 commits into from
Jul 3, 2019

Conversation

limebell
Copy link
Member

@limebell limebell commented Jul 3, 2019

Added changelog

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #326 into master will increase coverage by 0.34%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   87.34%   87.68%   +0.34%     
==========================================
  Files         189      189              
  Lines       12767    12711      -56     
==========================================
- Hits        11151    11146       -5     
+ Misses       1366     1315      -51     
  Partials      250      250
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 77.46% <100%> (+2.62%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.38% <86.66%> (+0.04%) ⬆️
Libplanet/Net/NoSwarmContextException.cs 25% <0%> (+25%) ⬆️

@earlbread earlbread requested review from longfin, earlbread and dahlia and removed request for longfin and earlbread July 3, 2019 08:51
CHANGES.md Outdated Show resolved Hide resolved
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
@longfin longfin merged commit 5be73dc into planetarium:master Jul 3, 2019
@longfin
Copy link
Member

longfin commented Jul 3, 2019

Thanks for contribution! 🎉

@limebell limebell deleted the remove-collection branch July 10, 2019 06:40
@limebell limebell restored the remove-collection branch July 10, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants