-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on gossip denial #3519
Fix bug on gossip denial #3519
Conversation
ca7e2ee
to
26e89d5
Compare
26e89d5
to
c595740
Compare
Are we sure we want this to be 3.6 based? 🤔 |
Wasn't? I've thought this have to be added to 3.6, since current mainnet uses 3.6.x. I'll change base of this PR to 3.8. |
c595740
to
f8a55be
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
6708233
into
planetarium:3.8-maintenance
There's a bug on gossip denial, and this PR fixes it.
Though adding
_peerCatchupRounds.Clear()
onGossipConsensusMessageCommunicator.cs L69
is enough to solve the problem, added some height validation not to be confused.(This will be needless after sync between
Gossip
andHeightVoteSet
)This PR Resolves