Add BlockAction flag to ActionContext #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
requested review from
OnedgeLee,
s2quake,
greymistcube and
riemannulus
and removed request for
s2quake
OnedgeLee
approved these changes
Apr 22, 2024
s2quake
reviewed
Apr 23, 2024
There was a problem hiding this comment.
It is common practice in .NET to prefix a bool type identifier with 'Is'. For example, refer to the following link: https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names.
The link does not specifically mention identifier names for bool types, but the example code in the link uses the is prefix. Your style preference may differ, but I would suggest using isBlockAction. blockAction seems like an instance of an action to me.
s2quake
reviewed
Apr 23, 2024
limebell
force-pushed
the
bugfix/tx-action-signer
branch
from
dfe79d2
to
a9df497
Compare
s2quake
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ActionContext.BlockActionwas determined by nullability ofTxIdfield, became to take argument directly.Fixed bug where TxActions' signer was block's proposer, not tx's.
Skips changelog because all API changes are internal.