Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #377 #378

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Fix #377 #378

merged 2 commits into from
Aug 2, 2019

Conversation

longfin
Copy link
Member

@longfin longfin commented Jul 30, 2019

This PR fixes #377

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #378 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   88.28%   88.22%   -0.06%     
==========================================
  Files         195      195              
  Lines       13847    13848       +1     
==========================================
- Hits        12225    12218       -7     
- Misses       1346     1354       +8     
  Partials      276      276
Impacted Files Coverage Δ
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (ø) ⬆️
Libplanet/Net/Swarm.cs 78.3% <0%> (-0.5%) ⬇️

@longfin longfin marked this pull request as ready for review July 30, 2019 03:39
@longfin longfin requested review from earlbread and dahlia July 30, 2019 03:46
earlbread
earlbread previously approved these changes Jul 30, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
earlbread
earlbread previously approved these changes Jul 31, 2019
longfin and others added 2 commits August 1, 2019 15:51
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@longfin longfin merged commit 21fef6a into planetarium:master Aug 2, 2019
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TurnClient has been crashed
3 participants