Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Deprecate PoW evaluation #3789

Merged

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented May 17, 2024

Related to #3790.

See the changelog for the ramification for deprecating PoW evaluation.
Further API fixes will be in subsequent PRs. These include

  • Removing IActionContext typed parameter from IWorld.TransferAsset()
  • Preventing IWorld with IWorld.Version less than BlockMetadata.PBFTProtocolVersion

and possibly more as they come up. 😶

@greymistcube greymistcube force-pushed the refactor/deprecate-pow-evaluation branch 4 times, most recently from f992c5b to 57c9b77 Compare May 21, 2024 05:13
@greymistcube greymistcube force-pushed the refactor/deprecate-pow-evaluation branch from 57c9b77 to 53432b0 Compare May 21, 2024 08:44
@greymistcube greymistcube force-pushed the refactor/deprecate-pow-evaluation branch from 53432b0 to 25bc5f2 Compare May 21, 2024 10:39
@riemannulus
Copy link
Member

Could you make sure to succeed Details?

@greymistcube
Copy link
Contributor Author

greymistcube commented May 23, 2024

Could you make sure to succeed Details?

@riemannulus
Just a test being flaky. It's solved. 🙄

@greymistcube greymistcube merged commit 801606c into planetarium:main May 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants