Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Added tests for unmarsahling PoW blocks #3791

Merged
merged 2 commits into from
May 20, 2024
Merged

🔧 Added tests for unmarsahling PoW blocks #3791

merged 2 commits into from
May 20, 2024

Conversation

greymistcube
Copy link
Contributor

🔧 Related to #3790.

Few notes:

  • As written in the comments, took valid blocks from past versions.
    • However, some modifications were made. Specifically, during protocol version 0 and 1, it seems like it was possible to have Block.StateRootHash to be null. This is not compatible with the current implementation.
  • Disabled warning of MEN002 as this should be easier to maintain and does not affect code readability much. 🙄

@greymistcube greymistcube self-assigned this May 20, 2024
@greymistcube greymistcube added the no changelog Bypasses changelog check label May 20, 2024
@greymistcube greymistcube marked this pull request as ready for review May 20, 2024 06:20
@greymistcube greymistcube mentioned this pull request May 20, 2024
Open
3 tasks
limebell
limebell reviewed May 20, 2024
View reviewed changes
Copy link
Member

@limebell limebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greymistcube greymistcube merged commit 38b56e3 into planetarium:main May 20, 2024
22 checks passed
@greymistcube greymistcube deleted the chore/legacy-block-bencodex branch May 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limebell limebell limebell left review comments

Assignees

@greymistcube greymistcube

Labels
no changelog Bypasses changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greymistcube @limebell