Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ ♻️ Refactor BlockLocator to include only one BlockHash #3913

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Aug 2, 2024

This should help with overall performance when syncing Blocks.
The update makes it incompatible with nodes using a previous version of Libplanet in terms of syncing Blocks.

@greymistcube greymistcube force-pushed the refactor/block-locator branch 2 times, most recently from 6934c4f to 99b5d8c Compare August 2, 2024 10:24
@greymistcube greymistcube force-pushed the refactor/block-locator branch from 99b5d8c to a09cc21 Compare August 9, 2024 08:47
@greymistcube greymistcube marked this pull request as ready for review August 9, 2024 08:48
@greymistcube greymistcube changed the title Refactor/block locator ⚡ ♻️ Refactor BlockLocator to include only one BlockHash Aug 9, 2024
riemannulus
riemannulus previously approved these changes Aug 17, 2024
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greymistcube greymistcube force-pushed the refactor/block-locator branch from a09cc21 to efef3c3 Compare August 20, 2024 15:50
@greymistcube greymistcube merged commit df313ba into planetarium:main Aug 20, 2024
22 checks passed
@greymistcube greymistcube deleted the refactor/block-locator branch September 6, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants