♻️ Simplified the internal behavior of GetDemandBlockHashes()
#3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymistcube
changed the title
GetDemandBlockHashes()
greymistcube
force-pushed
the
refactor/remove-chunksize
branch
from
cba76a1 to
57a5777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockHashes over multiple attempts.chunkSizeparameter. This was never clearly defined and was being used improperly in the first place.BlockHashes from aPeer, thePeerselection is done randomly (instead of trying to attempt from the "highest"Peerfirst).