Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove Fork() and Swap() #3948

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Sep 5, 2024

We can finally assume forking and swapping of chains would not happen through normal operations. 🙃
As such, once 5.3.0 is released, we can perform an analysis on an IStore and migrate/prune the internal DB and simplify the IStore interface accordingly.

@greymistcube greymistcube marked this pull request as ready for review September 6, 2024 01:31
@riemannulus
Copy link
Member

Here, in NineChronicles.Snapshot use a fork and swap afaik. Could you check it?

@greymistcube
Copy link
Contributor Author

@riemannulus

Here, in NineChronicles.Snapshot use a fork and swap afaik. Could you check it?

I have checked it. It is all done externally without using BlockChain.Fork() or BlockChain.Swap().
Although, I have been thinking maybe we should provide a tool to manipulate IStore and IStateStore more safely. 🙄

@riemannulus
Copy link
Member

Although, I have been thinking maybe we should provide a tool to manipulate IStore and IStateStore more safely. 🙄

Agree.

@greymistcube greymistcube merged commit 3b939e7 into planetarium:main Sep 6, 2024
23 checks passed
@greymistcube greymistcube deleted the refactor/remove-fork branch September 6, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants