Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Changed encoding of GetBlockHashesMsg and BlockHashesMsg #3949

Merged

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Sep 6, 2024

♻️

@greymistcube greymistcube force-pushed the refactor/message-encoding branch from 0ae6b36 to 443e1b6 Compare September 6, 2024 06:48
@greymistcube greymistcube changed the title Changed encoding of GetBlockHashesMsg and BlockHashesMsg ♻️ Changed encoding of GetBlockHashesMsg and BlockHashesMsg Sep 6, 2024
@greymistcube greymistcube marked this pull request as ready for review September 6, 2024 06:50
riemannulus
riemannulus previously approved these changes Sep 6, 2024
@greymistcube
Copy link
Contributor Author

Addendum: Removed unnecessary read lock since ContainsBlock() has a read lock inside.

@greymistcube greymistcube merged commit 3731ca4 into planetarium:main Sep 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants