Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔴 refactor: use Bitfaster.Caching instead of Libplanet.LruCahceNet #3962

Merged
merged 3 commits into from
Oct 10, 2024
Merged

🔴 refactor: use Bitfaster.Caching instead of Libplanet.LruCahceNet #3962

merged 3 commits into from
Oct 10, 2024

Conversation

riemannulus
Copy link
Member

@riemannulus riemannulus commented Oct 10, 2024 •
edited
Loading

Context

Benchmark says at all.

Benchmark

BenchmarkDotNet v0.14.0, macOS Sequoia 15.0 (24A335) [Darwin 24.0.0]
Apple M2 Max, 1 CPU, 12 logical and 12 physical cores
.NET SDK 8.0.101
  [Host]     : .NET 8.0.1 (8.0.123.58001), Arm64 RyuJIT AdvSIMD
  DefaultJob : .NET 8.0.1 (8.0.123.58001), Arm64 RyuJIT AdvSIMD

Read

Method Mean Error StdDev
ConcurrentLru 5.156 μs 0.0171 μs 0.0133 μs
ConcurrentTLru 5.372 μs 0.0161 μs 0.0150 μs
Planetarium.LruCacheNet 15.479 μs 0.0444 μs 0.0416 μs

Write

Method Mean Error StdDev
ConcurrentLru 26.45 μs 0.186 μs 0.165 μs
ConcurrentTLru 26.05 μs 0.056 μs 0.047 μs
Planetarium.LruCacheNet 16.63 μs 0.119 μs 0.099 μs

@riemannulus riemannulus self-assigned this Oct 10, 2024
@riemannulus riemannulus force-pushed the imp/use-bitfaster-caching branch from b61fbd5 to 90c524a Compare October 10, 2024 07:50
greymistcube
greymistcube approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@greymistcube greymistcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like everything is in order.

@riemannulus riemannulus merged commit 1fba38e into planetarium:main Oct 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnedgeLee OnedgeLee OnedgeLee approved these changes

@greymistcube greymistcube greymistcube approved these changes

Assignees

@riemannulus riemannulus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riemannulus @greymistcube @OnedgeLee