Boost PreloadAsync() #420
Boost PreloadAsync() #420
Conversation
longfin
force-pushed
the
feature/boost-ibd
branch
from
6d0e141
to
9bba9ab
Compare
longfin
force-pushed
the
feature/boost-ibd
branch
7 times, most recently
from
4049d43
to
00197ca
Compare
longfin
force-pushed
the
feature/boost-ibd
branch
3 times, most recently
from
13b17c5
to
f08577b
Compare
longfin
force-pushed
the
feature/boost-ibd
branch
from
f08577b
to
fc4bb70
Compare
|
I've rebased. PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=========================================
+ Coverage 87.97% 88% +0.03%
=========================================
Files 195 195
Lines 13675 13729 +54
=========================================
+ Hits 12030 12082 +52
- Misses 1332 1334 +2
Partials 313 313
|
longfin
force-pushed
the
feature/boost-ibd
branch
from
fc4bb70
to
c111e56
Compare
|
I've rebased to append it to 0.6.0. |
longfin
force-pushed
the
feature/boost-ibd
branch
from
c111e56
to
b46fb2c
Compare
| @@ -53,6 +53,26 @@ public interface IStore | |||
|
|
|||
| bool DeleteIndex(string @namespace, HashDigest<SHA256> hash); | |||
|
|
|||
| /// <summary> | |||
| /// Forks block indexes from | |||
There was a problem hiding this comment.
Does the term “block indexes” mean a sequence (chain) of block hashes and its index numbers? Or does it include state references? If it's latter the plural term seems natural for me as well, but if it's former I believe the singular term (i.e., “block index”) would listen more natural IMHO (as like the way other related methods are named, e.g., AppendIndex, DeleteIndex, IterateIndex).
There was a problem hiding this comment.
It's former. but I've confused about that because….
AppendIndex()andDeleteIndex()take only one argument.- Other iteration methods use plural form. (e.g.
IterateBlockHashes(),IterateStateReferences())
So, how about keep ForkIndexes() in this PR and rename IterateIndex() to IterateIndexes() in other PR?
There was a problem hiding this comment.
IMO in the case of this a singular noun “index” is more natural than a plural noun “indexes”/“indices,” in the same manner we say “a set of blocks” instead of “sets of blocks” to mean ISet[Block] in verbal language.
There was a problem hiding this comment.
I thought about this terminology once more, and it turns out the plural term has its own advantage, and I agree your suggestion to rename these method names to use the plural term “indexes” instead of the singular “index.” Some reasons:
- Although relational databases tend to say “an index” for values in a column, we also say “indices” in books.
- We already name a block's height by
Block.Index, so it's natural to say a collection ofBlock.Indexes as the plural “indexes.”
longfin
force-pushed
the
feature/boost-ibd
branch
from
b46fb2c
to
eb59e7c
Compare
- Use temporary memory to organize staterefs for avoid too many file writings - IStore.StoreStateReferences() became to take blockHash and blockIndex instead of the block itself. - Remove ReceivedAddress from StateReferenceDownloadState
- Add ForkBlockIndexes to IStore and LiteDBStore for fast fork
longfin
force-pushed
the
feature/boost-ibd
branch
from
eb59e7c
to
2d81e58
Compare
…bump-submodule Bump submodule
This patch enhances the performance of
Swarm.PreloadAsync()using two tricks as below.RecentStates.StateReferencesdirectly,PreloadAsyncbecame to translate this message asDictionary<HashDigest<SHA256>, ISet<Address>>to reduce file I/O.IStore.StoreStateReferencebecame to takeblockHashandblockIndex, not wholeBlock.PreloadAsync()are currently fork its chain to prevent corruption by unexpected termination. this patch reduces its file I/O byIStore.ForkIndexes()