Re-ordering Swarm<T>.StartAsync() #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Listen → (NAT check & set Endpoint & run TURN tasks) → preload → run & wait other tasks (+1 squashed commits)
longfin
force-pushed
the
feature/reorder-startasync
branch
from
4e14fd6
to
8962f5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 88.16% 88.22% +0.05%
==========================================
Files 198 198
Lines 14230 14221 -9
==========================================
Hits 12546 12546
+ Misses 1373 1364 -9
Partials 311 311
|
earlbread
approved these changes
Aug 12, 2019
dahlia
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the order of processes in
Swarm<T>.StartAsync()to avoid disabling TURN allocation even ifSwarm<T>.PreloadAsync()takes a long time.