Add Address(ImmutableArray<byte>) constructor #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
longfin
reviewed
Aug 16, 2019
CHANGES.md
Outdated
| @@ -29,6 +29,8 @@ To be released. | |||
| - Removed `IRandom.NextDouble()` method, because [floating-point arithmetics, | |||
| which is underspecified, likely introduce | |||
| indeterminism][floating-point determinism]. [[#410], [#419]] | |||
| - `Address(byte[])` became to throw `ArgumentNullException` | |||
| instead of `NullReferenceException`. [[#442], [#443]] | |||
There was a problem hiding this comment.
Actually, #442 doesn't seem to address it.
Suggested change
| instead of `NullReferenceException`. [[#442], [#443]] | |
| instead of `NullReferenceException`. [[#443]] |
moreal
requested changes
Aug 16, 2019
Libplanet/Address.cs
Outdated
| /// <see cref="Address"/> can be gotten using <see cref="ToByteArray()" | ||
| /// /> method.</remarks> | ||
| /// <seealso cref="ByteArray"/> | ||
| public Address(ImmutableArray<byte> address) { |
There was a problem hiding this comment.
Suggested change
| public Address(ImmutableArray<byte> address) { | |
| public Address(ImmutableArray<byte> address) | |
| { |
earlbread
reviewed
Aug 16, 2019
kanghyojun
force-pushed
the
address-cosntructor
branch
from
217e5c3
to
353c99c
Compare
kanghyojun
force-pushed
the
address-cosntructor
branch
from
353c99c
to
2708166
Compare
dahlia
approved these changes
Aug 16, 2019
earlbread
approved these changes
Aug 16, 2019
moreal
approved these changes
Aug 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 87.99% 83.56% -4.44%
==========================================
Files 198 174 -24
Lines 14489 13820 -669
==========================================
- Hits 12750 11549 -1201
- Misses 1424 1985 +561
+ Partials 315 286 -29
|
longfin
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address(byte[])became to throwArgumentNullExceptioninstead of
NullReferenceException.