Make all staged transactions broadcasted #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
approved these changes
Aug 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 88.1% 88.04% -0.06%
==========================================
Files 195 195
Lines 13721 13654 -67
==========================================
- Hits 12089 12022 -67
Misses 1320 1320
Partials 312 312
|
moreal
approved these changes
Aug 28, 2019
longfin
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the concept of “staged transactions that should not be broadcasted,” because its primary usage had been to make a transaction of a reward action for a candidate for block miner, and the case became achieved through
IBlockPolicy<T>.BlockActionproperty which was made by the patch #367.So all staged transactions became broadcasted.