Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnexpectedlyTerminatedActionException #498

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Sep 4, 2019

For the sake of easier debugging, this patch makes action evaluation to throw UnexpectedlyTerminatedActionException with having its InnerException, BlockHash, BlockIndex, and TxId if an action throws an exception.

@dahlia dahlia added the suggestion Suggestion or feature request label Sep 4, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 4, 2019
@dahlia dahlia self-assigned this Sep 4, 2019
longfin
longfin previously approved these changes Sep 4, 2019
earlbread
earlbread previously approved these changes Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #498 into master will increase coverage by 0.01%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   89.96%   89.98%   +0.01%     
==========================================
  Files         200      200              
  Lines       14506    14552      +46     
==========================================
+ Hits        13051    13095      +44     
+ Misses       1178     1173       -5     
- Partials      277      284       +7
Impacted Files Coverage Δ
Libplanet/Action/ActionEvaluation.cs 100% <100%> (+3.17%) ⬆️
...et/Action/UnexpectedlyTerminatedActionException.cs 100% <100%> (ø)
Libplanet/Tx/Transaction.cs 95.75% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.21% <100%> (ø) ⬆️
Libplanet.Tests/Tx/TransactionTest.cs 92.16% <66.66%> (-0.56%) ⬇️
Libplanet.Tests/Common/Action/ThrowException.cs 72% <80%> (+9.5%) ⬆️

moreal
moreal previously approved these changes Sep 4, 2019
@dahlia dahlia merged commit 21ac8d8 into planetarium:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Suggestion or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants