Remove IActionContext.NewGuid() & Add RandomExtension.GenerateRandomGuid()
#508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
longfin
reviewed
Sep 10, 2019
| /// <seealso cref="IRandom"/> | ||
| public static Guid GenerateRandomGuid(this IRandom random) | ||
| { | ||
| var bytes = new byte[16]; |
There was a problem hiding this comment.
It would be better if there is mention as this.
There was a problem hiding this comment.
Both are fixed! Thanks!
There was a problem hiding this comment.
@Unengine Still not addressed I think?
There was a problem hiding this comment.
Sorry, I forgot to commit. I'll also commit your suggestions at once!
dahlia
reviewed
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.02%
==========================================
Files 200 201 +1
Lines 14718 14718
==========================================
+ Hits 13254 13257 +3
+ Misses 1180 1177 -3
Partials 284 284
|
limebell
previously approved these changes
Sep 10, 2019
limebell
reviewed
Sep 10, 2019
You're right. Job's done! |
dahlia
reviewed
Sep 10, 2019
dahlia
approved these changes
Sep 10, 2019
limebell
approved these changes
Sep 10, 2019
earlbread
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think getting a random
GuidinIActionContextis a bad usage because dummy objects (for testing, debugging or etc ...) using randomGuidin games don't needIActionContext.IRandoms are enough to acquire the same thing.So I removed
IActionContext.NewGuid().Instead I added an extension class,
RandomExtensionthat includes a extension method,GenerateRandomGuid().Since
RandomExtensionis an extension class, I implemented generating a randomGuid.