Make the order of Block<T>.Transactions aware of their nonce #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
previously approved these changes
Sep 19, 2019
dahlia
force-pushed
the
block-execute-tx-nonce-order
branch
from
7427167
to
5a8764e
Compare
earlbread
previously approved these changes
Sep 19, 2019
limebell
previously approved these changes
Sep 19, 2019
moreal
previously approved these changes
Sep 19, 2019
dahlia
force-pushed
the
block-execute-tx-nonce-order
branch
from
5a8764e
to
392508b
Compare
moreal
approved these changes
Sep 19, 2019
earlbread
approved these changes
Sep 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
===========================================
+ Coverage 80.17% 90.18% +10.01%
===========================================
Files 61 201 +140
Lines 1513 14890 +13377
===========================================
+ Hits 1213 13429 +12216
- Misses 271 1185 +914
- Partials 29 276 +247
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also the changelog and comments in the
Block<T>()constructor.