-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LookupStateReference #545
Improve LookupStateReference #545
Conversation
8964451
to
5c6bd13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to test added parameters.
Libplanet/Store/IStore.cs
Outdated
@@ -198,14 +198,20 @@ AddressStateMap states | |||
/// </summary> | |||
/// <param name="chainId">The chain ID.</param> | |||
/// <param name="address">The <see cref="Address"/> to get state references.</param> | |||
/// <param name="highestIndex">The highest index of state references to get.</param> | |||
/// <param name="lowestIndex">The lowest index of state references to get.</param> | |||
/// <param name="limit">The maximum number of state references to get.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs should define what if these parameters take null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I elaborated the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems still the case of null
is not explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs were missing during the rebase. I restored.
5c6bd13
to
b668c68
Compare
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 90.88% 90.83% -0.06%
==========================================
Files 201 201
Lines 15172 15230 +58
==========================================
+ Hits 13789 13834 +45
- Misses 1100 1106 +6
- Partials 283 290 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have some tests for these added options?
b668c68
to
b862efb
Compare
I rebased this on the current master and added tests for new options. |
Improve `IStore.LookupStateReference()` method by limiting the number of results
b862efb
to
e95acc3
Compare
To mitigate #447, this improves
IStore.LookupStateReference()
method by limiting the number of results.