Improve LookupStateReference #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
force-pushed
the
improve-lookup-state-ref
branch
3 times, most recently
from
8964451
to
5c6bd13
Compare
limebell
previously approved these changes
Sep 30, 2019
dahlia
suggested changes
Sep 30, 2019
dahlia
reviewed
Sep 30, 2019
Libplanet/Store/IStore.cs
Outdated
| @@ -198,14 +198,20 @@ AddressStateMap states | |||
| /// </summary> | |||
| /// <param name="chainId">The chain ID.</param> | |||
| /// <param name="address">The <see cref="Address"/> to get state references.</param> | |||
| /// <param name="highestIndex">The highest index of state references to get.</param> | |||
| /// <param name="lowestIndex">The lowest index of state references to get.</param> | |||
| /// <param name="limit">The maximum number of state references to get.</param> | |||
There was a problem hiding this comment.
The docs should define what if these parameters take null.
There was a problem hiding this comment.
I elaborated the docs.
There was a problem hiding this comment.
Seems still the case of null is not explained.
There was a problem hiding this comment.
The docs were missing during the rebase. I restored.
earlbread
force-pushed
the
improve-lookup-state-ref
branch
from
5c6bd13
to
b668c68
Compare
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 90.88% 90.83% -0.06%
==========================================
Files 201 201
Lines 15172 15230 +58
==========================================
+ Hits 13789 13834 +45
- Misses 1100 1106 +6
- Partials 283 290 +7
|
dahlia
suggested changes
Oct 1, 2019
earlbread
force-pushed
the
improve-lookup-state-ref
branch
from
b668c68
to
b862efb
Compare
|
I rebased this on the current master and added tests for new options. |
limebell
previously approved these changes
Oct 7, 2019
longfin
previously approved these changes
Oct 7, 2019
Improve `IStore.LookupStateReference()` method by limiting the number of results
earlbread
force-pushed
the
improve-lookup-state-ref
branch
from
b862efb
to
e95acc3
Compare
dahlia
approved these changes
Oct 7, 2019
limebell
approved these changes
Oct 7, 2019
longfin
approved these changes
Oct 7, 2019
moreal
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate #447, this improves
IStore.LookupStateReference()method by limiting the number of results.