Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.0 as well as netcoreapp2.2 #561

Merged
merged 4 commits into from
Oct 11, 2019

Conversation

RozzaysRed
Copy link
Contributor

Addresses #209

@moreal
Copy link
Contributor

moreal commented Oct 4, 2019

/rebase

@longfin
Copy link
Member

longfin commented Oct 7, 2019

I think it needs to mention this change in the changelog.

@longfin longfin requested a review from libplanet October 7, 2019 01:57
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
RozzaysRed and others added 2 commits October 10, 2019 12:09
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #561 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   90.79%   90.82%   +0.03%     
==========================================
  Files         201      201              
  Lines       15219    15219              
==========================================
+ Hits        13818    13823       +5     
+ Misses       1111     1106       -5     
  Partials      290      290
Impacted Files Coverage Δ
Libplanet/Net/Protocols/KademliaProtocol.cs 60.54% <0%> (+0.81%) ⬆️
Libplanet/Net/NetMQSocketExtension.cs 81.63% <0%> (+4.08%) ⬆️

@longfin longfin merged commit 3172471 into planetarium:master Oct 11, 2019
@longfin
Copy link
Member

longfin commented Oct 11, 2019

@RozzaysRed Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants