Turn BlockChain.GetStates() into GetState() #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qtuu Great work! As you say, |
limebell
previously approved these changes
Oct 4, 2019
longfin
reviewed
Oct 7, 2019
earlbread
reviewed
Oct 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 90.86% 89.09% -1.77%
==========================================
Files 201 177 -24
Lines 15230 14532 -698
==========================================
- Hits 13838 12948 -890
- Misses 1101 1300 +199
+ Partials 291 284 -7
|
|
/rebase |
I am sorry. Should I have done a rebase merge? I am at loss here |
When no stateReference is found, we need to return early. This was done implicitly by iterating over an empty stateReferences-HashSet.
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
use pattern matching Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
earlbread
force-pushed
the
Turn-BlockChain-T-.GetStates()-into-GetState()
branch
from
2820872
to
45f82c8
Compare
We tried to do an automatic rebase, but it didn't work. So I rebased it manually. |
earlbread
approved these changes
Oct 7, 2019
longfin
approved these changes
Oct 7, 2019
limebell
approved these changes
Oct 8, 2019
|
@qtuu Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to solve Issue #510
It feels super wonky to still use AddressStateMap as a returnvalue, because it will always have just the one entry. I tried to make it return the (object) value instead, but failed misserably on a serialization-issue, breaking most of the use-cases.
If you guys want me to pursuit a better return value, i could try again...
Anyways, looking forward to your feedback :)