Access blocks and transactions of the chain with lock #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
Oct 15, 2019
Libplanet/Blockchain/BlockChain.cs
Outdated
| /// </param> | ||
| /// <exception cref="KeyNotFoundException">Thrown when there is no | ||
| /// <see cref="Transaction{T}"/> with a given <paramref name="txId"/>.</exception> | ||
| public Transaction<T> this[TxId txId] |
There was a problem hiding this comment.
Instead of overloading this and making indexer able to return two distinct types, how about declare a method like GetTransaction(TxId)?
There was a problem hiding this comment.
That would be better. Fixed.
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 90.74% 90.72% -0.02%
==========================================
Files 202 202
Lines 15514 15542 +28
==========================================
+ Hits 14078 14101 +23
- Misses 1144 1149 +5
Partials 292 292
|
limebell
previously approved these changes
Oct 15, 2019
moreal
previously approved these changes
Oct 15, 2019
longfin
previously approved these changes
Oct 15, 2019
|
I think that we also need to add a mutex for block synchronization to |
dahlia
previously approved these changes
Oct 15, 2019
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
dahlia
approved these changes
Oct 15, 2019
longfin
approved these changes
Oct 15, 2019
limebell
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#409 occurs when a task tries to read a block or transaction from
BlockChain<T>.BlocksorBlockChain<T>.Transactionswhile another task is writing it. This fixes #409 by changing blocks and transactions in theBlockChain<T>so that it cannot be accessed without the lock from the outside of the chain.