Mark Address and HashDigest as readonly #605

[FrancescoBonizzi]

I made Address and HashDigest readonly.

[codecov]

Codecov Report

Merging #610 into master will decrease coverage by 0.03%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
- Coverage   90.92%   90.88%   -0.04%     
==========================================
  Files         202      202              
  Lines       15757    15761       +4     
==========================================
- Hits        14327    14325       -2     
  Misses       1131     1131              
- Partials      299      305       +6

Impacted Files	Coverage Δ
Libplanet/Address.cs	90.65% <40%> (-2.68%)	⬇️
Libplanet/HashDigest.cs	96.42% <40%> (-3.58%)	⬇️

[longfin]

@FrancescoBonizzi Thanks for your work! I left some comments about changes.

[FrancescoBonizzi]

@longfin I made the changes you suggested!

[longfin]

Great work! 💯

[earlbread]

👍

[longfin]

@FrancescoBonizzi This PR seems to have conflicts due to merging another PR(#609). could you rebase this branch(FrancescoBonizzi:ForIssue605) onto master?

[FrancescoBonizzi]

@longfin I rebased but It seems nothing changed.

Could you please help me? :-)

[longfin]

@longfin I rebased but It seems nothing changed.

Could you please help me? :-)

I guess it needs to pulling master from upstream(git@github.com:planetarium/libplanet.net.git) before rebasing.

[FrancescoBonizzi]

@longfin I rebased but It seems nothing changed.
Could you please help me? :-)

I guess it needs to pulling master from upstream(git@github.com:planetarium/libplanet.net.git) before rebasing.

I did it, it doesn't work either. Maybe can I try to resolve conflicts? It seems to be just on the CHANGES row

[longfin]

@FrancescoBonizzi I've rebased and resolved conflict on CHNAGES.md.

If you want to make other changes on FrancescoBonizzi:ForIssue605, please use git pull --rebase to rebase your local tree too.

[FrancescoBonizzi]

@FrancescoBonizzi I've rebased and resolved conflict on CHNAGES.md.

If you want to make other changes on FrancescoBonizzi:ForIssue605, please use git pull --rebase to rebase your local tree too.

Thanks a lot!