-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Address and HashDigest as readonly #605 #610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 90.92% 90.88% -0.04%
==========================================
Files 202 202
Lines 15757 15761 +4
==========================================
- Hits 14327 14325 -2
Misses 1131 1131
- Partials 299 305 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrancescoBonizzi Thanks for your work! I left some comments about changes.
@longfin I made the changes you suggested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@FrancescoBonizzi This PR seems to have conflicts due to merging another PR(#609). could you rebase this branch( |
@longfin I rebased but It seems nothing changed. Could you please help me? :-) |
I guess it needs to pulling |
I did it, it doesn't work either. Maybe can I try to resolve conflicts? It seems to be just on the |
9985d4b
@FrancescoBonizzi I've rebased and resolved conflict on If you want to make other changes on |
Thanks a lot! |
I made
Address
andHashDigest
readonly.