SyncPreviousBlocksAsync deletes chains only created during FillBlocksAsync #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=========================================
- Coverage 88.25% 88.15% -0.1%
=========================================
Files 217 217
Lines 17174 17191 +17
=========================================
- Hits 15157 15155 -2
- Misses 1141 1159 +18
- Partials 876 877 +1
|
longfin
reviewed
Nov 1, 2019
limebell
force-pushed
the
fillblock-fail
branch
from
e3dc07a
to
e91f7a4
Compare
earlbread
reviewed
Nov 1, 2019
dahlia
reviewed
Nov 1, 2019
limebell
force-pushed
the
fillblock-fail
branch
from
e91f7a4
to
2c081bd
Compare
longfin
approved these changes
Nov 1, 2019
earlbread
approved these changes
Nov 1, 2019
moreal
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that chain is reset when IBD fails.