Fix the canonical chain is deleted #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 87.33% 87.34% +0.01%
==========================================
Files 218 218
Lines 17760 17781 +21
==========================================
+ Hits 15510 15531 +21
- Misses 1187 1192 +5
+ Partials 1063 1058 -5
|
longfin
previously approved these changes
Nov 14, 2019
dahlia
reviewed
Nov 14, 2019
Libplanet.Tests/Net/SwarmTest.cs
Outdated
| await BootstrapAsync(swarmA, swarmB.AsPeer); | ||
|
|
||
| swarmA.BroadcastBlocks(new[] { block }); | ||
| await Task.Delay(100); |
There was a problem hiding this comment.
This scenario seems likely to make the test flaky, because swarmA.BroadcastBlocks(new[] { block }) could be faster than we assume… how about watching chainB.TipChanged event instead?
There was a problem hiding this comment.
Unfortunately, we can't use the TipChanged event because block downloading should be failed before block appending is complete.
There was a problem hiding this comment.
Could we make a new event to test this then?
There was a problem hiding this comment.
I added Swarm<T>. FillBlocksAsyncFailed for this test case.
earlbread
force-pushed
the
fix-chain-delete
branch
from
bd35912
to
7997905
Compare
dahlia
previously approved these changes
Nov 14, 2019
longfin
previously approved these changes
Nov 14, 2019
limebell
previously approved these changes
Nov 14, 2019
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
earlbread
force-pushed
the
fix-chain-delete
branch
from
7997905
to
0bb5b95
Compare
longfin
approved these changes
Nov 14, 2019
moreal
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed a bug where the canonical chain would be deleted if block download failed.