Move BlockChain<T>.Contains(TxId) to IStore #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
Nov 14, 2019
earlbread
reviewed
Nov 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=========================================
- Coverage 87.31% 87.3% -0.02%
=========================================
Files 218 218
Lines 17781 17789 +8
=========================================
+ Hits 15526 15531 +5
- Misses 1193 1196 +3
Partials 1062 1062
|
longfin
force-pushed
the
feature/seperate-contains-from-chain
branch
from
227eff2
to
ffd81d1
Compare
limebell
previously approved these changes
Nov 14, 2019
longfin
force-pushed
the
feature/seperate-contains-from-chain
branch
from
ffd81d1
to
5589844
Compare
limebell
approved these changes
Nov 14, 2019
earlbread
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
BlockChain<T>.Contains(TxId)toIStoreto separate the global transaction view fromBlockChain<T>.