Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable NetMQRuntime count #727

Merged
merged 2 commits into from
Dec 14, 2019

Conversation

wwhurin
Copy link
Contributor

@wwhurin wwhurin commented Dec 14, 2019

Title says it all.

@dahlia
Copy link
Contributor

dahlia commented Dec 14, 2019

/rebase

earlbread
earlbread previously approved these changes Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #727 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   86.65%   86.67%   +0.01%     
==========================================
  Files         221      221              
  Lines       18737    18741       +4     
==========================================
+ Hits        16236    16243       +7     
+ Misses       1344     1341       -3     
  Partials     1157     1157
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 82.95% <100%> (+0.02%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 95.86% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KBucket.cs 93.69% <0%> (+2.7%) ⬆️

longfin
longfin previously approved these changes Dec 14, 2019
Copy link
Member

@longfin longfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@wwhurin wwhurin dismissed stale reviews from longfin and earlbread via a275393 December 14, 2019 06:22
@wwhurin wwhurin force-pushed the configurable-netmqruntime-count branch from d2b1763 to a275393 Compare December 14, 2019 06:22
CHANGES.md Outdated Show resolved Hide resolved
@wwhurin wwhurin force-pushed the configurable-netmqruntime-count branch from a275393 to e08a220 Compare December 14, 2019 06:23
@dahlia dahlia requested a review from limebell December 14, 2019 06:23
@limebell limebell merged commit 8bed290 into planetarium:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants