Tune Swarm<T> #744
Merged
Tune Swarm<T> #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase concurrency - Remove unecessary assertion
longfin
force-pushed
the
bugfix/NAT-detection
branch
from
1cc15b3
to
27cd9ec
Compare
earlbread
reviewed
Dec 27, 2019
Libplanet/Net/Swarm.cs
Outdated
| { | ||
| } | ||
| }); | ||
| catch (NetMQException) |
There was a problem hiding this comment.
How about adding logs when these exceptions occur?
There was a problem hiding this comment.
I added logs at e337696.
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 86.54% 86.51% -0.04%
==========================================
Files 222 222
Lines 19209 19232 +23
==========================================
+ Hits 16624 16638 +14
- Misses 1404 1414 +10
+ Partials 1181 1180 -1
|
earlbread
previously approved these changes
Dec 27, 2019
|
I added a commit(b63489e) to address an issue that a peer can't request TURN relay properly when it has IPv6 address. |
earlbread
previously approved these changes
Dec 27, 2019
dahlia
reviewed
Dec 27, 2019
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
earlbread
approved these changes
Dec 27, 2019
dahlia
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues as below
Swarm<T>.StartAsync()had thrownNullReferenceExceptionwhen without using NAT andhostparameter.Swarm<T>._runtimeProcessorbecame a long-running task. (it's a dedicated thread.)Swarm<T>became spawn moreBindingProxies()to handle TURN request concurrently.