-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune Swarm<T> #744
Tune Swarm<T> #744
Conversation
- Increase concurrency - Remove unecessary assertion
1cc15b3
to
27cd9ec
Compare
Libplanet/Net/Swarm.cs
Outdated
{ | ||
} | ||
}); | ||
catch (NetMQException) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding logs when these exceptions occur?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added logs at e337696.
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 86.54% 86.51% -0.04%
==========================================
Files 222 222
Lines 19209 19232 +23
==========================================
+ Hits 16624 16638 +14
- Misses 1404 1414 +10
+ Partials 1181 1180 -1
|
I added a commit(b63489e) to address an issue that a peer can't request TURN relay properly when it has IPv6 address. |
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
This PR addresses some issues as below
Swarm<T>.StartAsync()
had thrownNullReferenceException
when without using NAT andhost
parameter.Swarm<T>._runtimeProcessor
became a long-running task. (it's a dedicated thread.)Swarm<T>
became spawn moreBindingProxies()
to handle TURN request concurrently.