Unsure to merge: Compress blocks and txs as well #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[changelog skip]
dahlia
added
discussion needed
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 86.4% 86.48% +0.08%
==========================================
Files 222 223 +1
Lines 19218 19273 +55
==========================================
+ Hits 16605 16669 +64
+ Misses 1419 1410 -9
Partials 1194 1194
|
|
I guess it's okay that we contain this feature and can also drop out when it is obvious that it is not necessary or harmful to features. |
longfin
reviewed
Jan 15, 2020
| deflate.Flush(); | ||
| buffer.Flush(); | ||
| int length = (int)buffer.Position; | ||
| var output = new byte[length]; |
There was a problem hiding this comment.
Can we use buffer.ToArray() instead of temp variable(output)?
| deflate.Flush(); | ||
| outputBuffer.Flush(); | ||
| int length = (int)outputBuffer.Position; | ||
| var output = new byte[length]; |
There was a problem hiding this comment.
Can we use outputBuffer.ToArray() instead of temp variable(output)?
|
As this patch does not solve the problem and is likely to make the code more complicated, I decided to do not merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is continued from #753. Besides block states, this compresses blocks and txs as well. Unfortunately, the compression rate is almost the same to #753 (5.1G → 1.6G).