Broadcast single block header instead of block hashes #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
force-pushed
the
refactor/header-based-message
branch
2 times, most recently
from
386b14e
to
fde68f6
Compare
earlbread
previously approved these changes
Jan 16, 2020
dahlia
reviewed
Jan 16, 2020
moreal
reviewed
Jan 16, 2020
|
This seems to need to resolve the conflict and to be rebased on the current master. |
limebell
force-pushed
the
refactor/header-based-message
branch
from
fde68f6
to
e8ae5de
Compare
dahlia
previously approved these changes
Jan 16, 2020
moreal
previously approved these changes
Jan 16, 2020
earlbread
previously approved these changes
Jan 17, 2020
limebell
force-pushed
the
refactor/header-based-message
branch
from
e8ae5de
to
717c31d
Compare
dahlia
suggested changes
Jan 21, 2020
dahlia
reviewed
Jan 21, 2020
dahlia
approved these changes
Jan 21, 2020
dahlia
previously approved these changes
Jan 21, 2020
longfin
reviewed
Jan 21, 2020
longfin
previously approved these changes
Jan 22, 2020
Apply requested changes Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
limebell
force-pushed
the
refactor/header-based-message
branch
from
3f8fd77
to
1331417
Compare
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=========================================
Coverage ? 86.32%
=========================================
Files ? 225
Lines ? 19280
Branches ? 0
=========================================
Hits ? 16644
Misses ? 1434
Partials ? 1202
|
longfin
approved these changes
Jan 22, 2020
moreal
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can ignore a block in different branch with lower index by this patch. See #757.