Improve performance of Swarm<T>
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/improve-perf-txs
branch
from
3f5f4b9
to
ba399f1
Compare
longfin
force-pushed
the
feature/improve-perf-txs
branch
from
ba399f1
to
d0dfb7c
Compare
moreal
previously approved these changes
Mar 30, 2020
dahlia
previously approved these changes
Mar 30, 2020
earlbread
previously approved these changes
Mar 30, 2020
longfin
force-pushed
the
feature/improve-perf-txs
branch
from
d0dfb7c
to
74cd0d5
Compare
|
@dahlia @earlbread @moreal I've missed some points, so I also amended commits. |
dahlia
previously approved these changes
Mar 30, 2020
longfin
force-pushed
the
feature/improve-perf-txs
branch
from
74cd0d5
to
d076ae8
Compare
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 87.44% 87.50% +0.05%
==========================================
Files 249 249
Lines 22507 22520 +13
==========================================
+ Hits 19682 19705 +23
+ Misses 1480 1471 -9
+ Partials 1345 1344 -1
|
moreal
approved these changes
Mar 30, 2020
earlbread
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
Swarm<T>by preventing unnecessary task creation.