Fix Swarm<T>.Preload() #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
bugfix/ibd-report
branch
from
87a60f3
to
2237f38
Compare
longfin
added
bug
longfin
force-pushed
the
bugfix/ibd-report
branch
from
9498006
to
570b2f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 87.47% 87.48% +0.01%
==========================================
Files 249 249
Lines 22520 22570 +50
==========================================
+ Hits 19699 19746 +47
- Misses 1475 1480 +5
+ Partials 1346 1344 -2
|
earlbread
previously approved these changes
Apr 2, 2020
dahlia
reviewed
Apr 2, 2020
earlbread
previously approved these changes
Apr 2, 2020
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/ibd-report
branch
from
14a521d
to
d064f7b
Compare
dahlia
previously approved these changes
Apr 2, 2020
longfin
force-pushed
the
bugfix/ibd-report
branch
2 times, most recently
from
539b901
to
c3ae3f0
Compare
|
I've amended 01994c4 to clean up the internal queue properly. |
longfin
force-pushed
the
bugfix/ibd-report
branch
2 times, most recently
from
4cd1abf
to
fbc1d55
Compare
|
I've amended 0f689a9 again and it seems to pass all tests. @dahlia @moreal @earlbread Please review once more. |
earlbread
previously approved these changes
Apr 3, 2020
moreal
previously approved these changes
Apr 3, 2020
dahlia
previously approved these changes
Apr 3, 2020
longfin
added a commit
to longfin/libplanet.net
that referenced
this pull request
Apr 3, 2020
earlbread
previously approved these changes
Apr 3, 2020
|
I've added e44d443 to apply suggestions. |
dahlia
previously approved these changes
Apr 3, 2020
moreal
previously approved these changes
Apr 3, 2020
longfin
force-pushed
the
bugfix/ibd-report
branch
from
2bf6f88
to
35c5726
Compare
dahlia
approved these changes
Apr 3, 2020
moreal
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two problems of
Swarm<T>.Preload().Swarm<T>hadn't reported preload states correctly.Swarm<T>.PreloadAsync()method's bug that it had hung forever when a block fetch failed due to an unexpected error.