Separate _poller in NetMQTransport #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/858
branch
2 times, most recently
from
88ae677
to
cbb0c2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
- Coverage 87.50% 87.48% -0.02%
==========================================
Files 249 249
Lines 22638 22651 +13
==========================================
+ Hits 19810 19817 +7
- Misses 1482 1488 +6
Partials 1346 1346
|
longfin
changed the title
earlbread
previously approved these changes
May 4, 2020
moreal
previously approved these changes
May 4, 2020
dahlia
reviewed
May 4, 2020
dahlia
approved these changes
May 4, 2020
earlbread
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR divides
_pollerby_routerPollerand_broadcastPollerto avoid unexpected blocking and improve throughput.