-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 'BindingProxies' from 'NetMQTransport' into 'TurnClient' #868
Move 'BindingProxies' from 'NetMQTransport' into 'TurnClient' #868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the changelog for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to pass the cancellation token in the missing part.
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 87.53% 87.55% +0.01%
==========================================
Files 250 250
Lines 22688 22683 -5
==========================================
- Hits 19860 19859 -1
+ Misses 1482 1478 -4
Partials 1346 1346
|
a9053fb
This PR should be resolve #756.