Clean up only temporary chains only #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
bugfix/delete-only
branch
from
74dffb6
to
2d5fbba
Compare
dahlia
reviewed
Jun 9, 2020
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 87.41% 87.19% -0.23%
==========================================
Files 252 248 -4
Lines 23202 22534 -668
==========================================
- Hits 20283 19649 -634
+ Misses 1542 1519 -23
+ Partials 1377 1366 -11
|
earlbread
approved these changes
Jun 9, 2020
dahlia
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Swarm<T>.Preloadto clean up temporary chains only.