Fixed TurnClient's cancellation bug #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
added
bug
longfin
force-pushed
the
bugfix/turn-cancellation
branch
from
692cb6a
to
5996e4f
Compare
longfin
requested review from
dahlia,
moreal,
limebell,
earlbread and
riemannulus
dahlia
approved these changes
Jul 7, 2020
riemannulus
approved these changes
Jul 7, 2020
earlbread
approved these changes
Jul 7, 2020
moreal
approved these changes
Jul 7, 2020
limebell
approved these changes
Jul 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 87.82% 87.78% -0.04%
==========================================
Files 258 258
Lines 23961 23962 +1
==========================================
- Hits 21044 21036 -8
- Misses 1517 1523 +6
- Partials 1400 1403 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses that
TurnClient.SendMessageAsync()hadn't been applied cancellation token as expected.