-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw exception when connecting to all neighbors fails #933
Don't throw exception when connecting to all neighbors fails #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 87.96% 88.03% +0.07%
==========================================
Files 263 263
Lines 24223 24200 -23
==========================================
- Hits 21307 21304 -3
+ Misses 1512 1489 -23
- Partials 1404 1407 +3
|
!(task.Exception is null) && | ||
task.Exception.InnerExceptions.All(ex => ex is TimeoutException))) | ||
{ | ||
throw new TimeoutException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we log inner exceptions in other places? If not it might better to log them here. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the inner exceptions are logged here. https://github.com/planetarium/libplanet/pull/933/files#diff-ae527d5afcdf41da4a57b594cab3cfefL655
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
c9ae648
to
2495685
Compare
I removed another exception https://github.com/planetarium/libplanet/pull/933/files#diff-ae527d5afcdf41da4a57b594cab3cfefL698 |
This PR changes to not throw an exception in
Swarm.BootstrapAsync()
when connecting to all neighbors fails.