-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PeerChainState #936
Add PeerChainState #936
Conversation
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
+ Coverage 87.97% 88.00% +0.02%
==========================================
Files 263 264 +1
Lines 24200 24258 +58
==========================================
+ Hits 21291 21349 +58
+ Misses 1504 1502 -2
- Partials 1405 1407 +2
|
I changed an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming PeerChainStatus
to PeerChainState
? Cf. https://english.stackexchange.com/questions/12958/status-vs-state. /cc @planetarium/libplanet
I think that's good. I'll rename it. |
Currently, |
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
I thought about it at first, but to do that, the current internal |
OH I made mistake, you're right. |
This adds
PeerChainStatus
struct andSwarm<T>.GetPeerChainStatus()
method to check the chain status of the connected peers.