Restartable Swarm<T> #965
Merged
Restartable Swarm<T> #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
bugfix/restart-swarm
branch
2 times, most recently
from
65fe30f
to
062ff44
Compare
longfin
requested review from
dahlia,
earlbread,
moreal,
limebell and
riemannulus
|
CI pipeline seems failed. can you check it first? |
longfin
force-pushed
the
bugfix/restart-swarm
branch
from
062ff44
to
cccf457
Compare
Thanks for telling me. fixed. |
longfin
force-pushed
the
bugfix/restart-swarm
branch
from
cccf457
to
a3261b5
Compare
limebell
reviewed
Aug 26, 2020
earlbread
previously approved these changes
Aug 26, 2020
moreal
previously approved these changes
Aug 26, 2020
dahlia
reviewed
Aug 26, 2020
longfin
force-pushed
the
bugfix/restart-swarm
branch
from
ea93313
to
3a3b20c
Compare
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
moreal
approved these changes
Aug 26, 2020
limebell
approved these changes
Aug 26, 2020
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 88.81% 88.70% -0.11%
==========================================
Files 288 315 +27
Lines 26766 27714 +948
==========================================
+ Hits 23771 24584 +813
- Misses 1466 1584 +118
- Partials 1529 1546 +17
|
dahlia
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that
Swarm<T>hadn't started afterSwarm<T>.StopAsync().