Fix errors on TurnClient #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
added
bug
longfin
requested review from
dahlia,
moreal,
earlbread,
limebell and
riemannulus
|
fe0f6f5 misaddresses #969 that covered by #906. ( but I guess some tweak-able points remains...
so I'll remove this commit about #969 from this PR and create another PR for that. |
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 88.73% 88.71% -0.03%
==========================================
Files 315 315
Lines 27683 27687 +4
==========================================
- Hits 24565 24563 -2
- Misses 1573 1577 +4
- Partials 1545 1547 +2
|
earlbread
previously approved these changes
Aug 28, 2020
moreal
previously approved these changes
Aug 28, 2020
|
/rebase |
riemannulus
previously approved these changes
Aug 28, 2020
github-actions
bot
dismissed stale reviews from riemannulus, moreal, and earlbread
via
f9312c2
github-actions
bot
force-pushed
the
bugfix/969
branch
from
feba082
to
f9312c2
Compare
earlbread
previously approved these changes
Aug 28, 2020
moreal
previously approved these changes
Aug 28, 2020
limebell
previously approved these changes
Aug 28, 2020
dahlia
approved these changes
Aug 28, 2020
riemannulus
approved these changes
Aug 28, 2020
moreal
approved these changes
Aug 28, 2020
earlbread
approved these changes
Aug 28, 2020
limebell
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #957
and #969.