DelayedRenderer<T> & DelayedActionRenderer<T> for stable app-side state transfer #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
force-pushed
the
delayed-renderer
branch
from
db3040b
to
2aa3cb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 88.88% 89.04% +0.16%
==========================================
Files 320 324 +4
Lines 28132 29060 +928
==========================================
+ Hits 25004 25876 +872
- Misses 1598 1629 +31
- Partials 1530 1555 +25
|
dahlia
force-pushed
the
delayed-renderer
branch
3 times, most recently
from
4319d95
to
7a084d8
Compare
…ock<T>> as well [changelog skip]
dahlia
force-pushed
the
delayed-renderer
branch
from
7a084d8
to
e09460d
Compare
dahlia
changed the title
dahlia
requested review from
moreal,
earlbread,
longfin,
limebell and
riemannulus
longfin
reviewed
Sep 4, 2020
dahlia
force-pushed
the
delayed-renderer
branch
from
e09460d
to
a5fb352
Compare
riemannulus
reviewed
Sep 4, 2020
Comment on lines
+749
to
+754
| IActionRenderer<DumbAction> renderer = new AnonymousActionRenderer<DumbAction> | ||
| { | ||
| ActionRenderer = (_, __, nextStates) => | ||
| throw new SomeException("thrown by renderer"), | ||
| }; | ||
| renderer = new LoggedActionRenderer<DumbAction>(renderer, Log.Logger); |
There was a problem hiding this comment.
That's the way to use LoggedActionRenderer<T> as it uses decorator pattern. See also the example code in its docs.
earlbread
reviewed
Sep 4, 2020
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Sep 4, 2020
dahlia
force-pushed
the
delayed-renderer
branch
from
a5fb352
to
0ba1b20
Compare
dahlia
force-pushed
the
delayed-renderer
branch
from
0ba1b20
to
ad32f96
Compare
earlbread
previously approved these changes
Sep 4, 2020
|
@planetarium/libplanet I make multiple renderers guaranteed to get their own distinct action contexts (i.e., one renderer consuming its random state does not affect other one's random state): 4e62c1b. Please review this again! |
longfin
reviewed
Sep 4, 2020
| { | ||
| throw new ArgumentException( | ||
| "Some previous blocks of two blocks are orphan.", | ||
| nameof(a) |
There was a problem hiding this comment.
ArgumentException seems designed for only one argument. 🤔
There was a problem hiding this comment.
Indeed I had thought the same question, and anyway I have no idea…
longfin
approved these changes
Sep 4, 2020
moreal
approved these changes
Sep 4, 2020
dahlia
added a commit
to dahlia/NineChronicles.Headless
that referenced
this pull request
Sep 4, 2020
to use delayed renderers. See also: planetarium/libplanet#980
dahlia
added a commit
to dahlia/NineChronicles.Headless
that referenced
this pull request
Sep 4, 2020
to use delayed renderers. See also: planetarium/libplanet#980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
DelayedRenderer<T>&DelayedActionRenderer<T>that decorate anotherIRenderer<T>&IActionRenderer<T>and delay rendering events until the certain number of descendant blocks confirm a block. See also the unit tests and XML comments.