-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FindSpecificPeerAsync's depth parameter did not worked properly #987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we have KademliaProtocolTest
or NetMQTransportTest
in the future…
Codecov Report
@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 89.04% 89.06% +0.01%
==========================================
Files 324 324
Lines 29164 29206 +42
==========================================
+ Hits 25968 26011 +43
+ Misses 1635 1631 -4
- Partials 1561 1564 +3
|
b7e33b9
to
277abce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems outdated; needs to rebase.
30535f1
277abce
to
30535f1
Compare
30535f1
to
6b2e7dd
Compare
I also added a regression test for the case.