Fix FindSpecificPeerAsync's depth parameter did not worked properly #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dahlia,
earlbread,
longfin,
moreal and
riemannulus
dahlia
previously approved these changes
Sep 7, 2020
earlbread
previously approved these changes
Sep 7, 2020
Codecov Report
@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 89.04% 89.06% +0.01%
==========================================
Files 324 324
Lines 29164 29206 +42
==========================================
+ Hits 25968 26011 +43
+ Misses 1635 1631 -4
- Partials 1561 1564 +3
|
limebell
force-pushed
the
bugfix/find-peer-depth
branch
from
b7e33b9
to
277abce
Compare
longfin
previously approved these changes
Sep 7, 2020
riemannulus
previously approved these changes
Sep 8, 2020
moreal
previously approved these changes
Sep 8, 2020
dahlia
previously approved these changes
Sep 8, 2020
limebell
dismissed stale reviews from dahlia, moreal, riemannulus, and longfin
via
30535f1
limebell
force-pushed
the
bugfix/find-peer-depth
branch
from
277abce
to
30535f1
Compare
earlbread
previously approved these changes
Sep 9, 2020
longfin
previously approved these changes
Sep 9, 2020
limebell
force-pushed
the
bugfix/find-peer-depth
branch
from
30535f1
to
6b2e7dd
Compare
riemannulus
approved these changes
Sep 10, 2020
dahlia
approved these changes
Sep 10, 2020
earlbread
approved these changes
Sep 10, 2020
earlbread
approved these changes
Sep 10, 2020
longfin
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a regression test for the case.