Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing Swarm<T> #996

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Polishing Swarm<T> #996

merged 3 commits into from
Sep 10, 2020

Conversation

longfin
Copy link
Member

@longfin longfin commented Sep 10, 2020

This PR addresses two bugs in Swarm<T> as below

  1. a bug that Swarm<T> had not received block headers after failing to receive previous blocks.
  2. a bug that Swarm<T> had thrown InvalidGenesisBlockException when reorg chain repeatedly.

@longfin longfin self-assigned this Sep 10, 2020
@longfin longfin changed the title Bugfix/swarm polish Polishing Swarm<T Sep 10, 2020
@dahlia dahlia changed the title Polishing Swarm<T Polishing Swarm<T> Sep 10, 2020
@longfin longfin added bug Something isn't working network Related to networking (Libplanet.Net) labels Sep 10, 2020
@longfin longfin marked this pull request as ready for review September 10, 2020 08:56
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #996 into main will increase coverage by 0.36%.
The diff coverage is 90.19%.

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   88.81%   89.17%   +0.36%     
==========================================
  Files         288      324      +36     
  Lines       26766    29301    +2535     
==========================================
+ Hits        23771    26130    +2359     
- Misses       1466     1608     +142     
- Partials     1529     1563      +34     
Impacted Files Coverage Δ
...ests/Blockchain/Renderers/AnonymousRendererTest.cs 83.87% <ø> (-3.72%) ⬇️
...t.Tests/Blockchain/Renderers/LoggedRendererTest.cs 99.11% <ø> (-0.14%) ⬇️
Libplanet.Tests/Common/Action/ExecuteRecord.cs 60.00% <0.00%> (-40.00%) ⬇️
Libplanet.Tests/Common/DumbRenderer.cs 93.33% <ø> (ø)
Libplanet.Tests/Net/SwarmTest.Fixtures.cs 100.00% <ø> (ø)
...lanet.Tests/Net/SwarmTest.TrustedStateCompleter.cs 98.63% <ø> (ø)
Libplanet.Tests/Store/StateStoreTracker.cs 60.00% <0.00%> (ø)
Libplanet/Action/PolymorphicAction.cs 100.00% <ø> (ø)
...ibplanet/Blockchain/Renderers/AnonymousRenderer.cs 100.00% <ø> (ø)
Libplanet/Blocks/Block.cs 85.42% <ø> (-0.20%) ⬇️
... and 106 more

@longfin longfin merged commit 915b94e into planetarium:main Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working network Related to networking (Libplanet.Net)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants