Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

add printing template endpoint #5

Merged
merged 1 commit into from
Jul 12, 2012
Merged

add printing template endpoint #5

merged 1 commit into from
Jul 12, 2012

Conversation

rmarianski
Copy link

  • new printing app that gets wired up in settings
  • new PrintTemplate model - can be managed by admin
  • view that interprets the contents of the model, and returns it as html
  • fixture that loads an initial template

@mpriour - can you try this out and merge into the printing branch if this is ok?

* new printing app that gets wired up in settings
* new PrintTemplate model - can be managed by admin
* view that interprets the contents of the model, and returns it as html
* fixture that loads an initial template
mpriour pushed a commit that referenced this pull request Jul 12, 2012
add printing template endpoint
@mpriour mpriour merged commit 126ddf0 into printing Jul 12, 2012
@mpriour
Copy link

mpriour commented Jul 13, 2012

Thanks for the quick turn around on this.

@rmarianski
Copy link
Author

Whatever makes more sense. I'm not invested in having the templates in the database :)

So you're not thinking that geonode would store the templates themselves? They would just be "ghost" objects in the database that had uri's to the templates?

@mpriour
Copy link

mpriour commented Jul 13, 2012

Maybe template content makes sense for local templates. I can see the problems with ghost objects as files could be removed / renamed and totally mess things up.
However, remote URL templates could change content and you would have no notification. So maybe, have both content & url fields and if content is non null, use that, otherwise use the url

@jj0hns0n
Copy link

I think @mpriour's suggestion is good (at least for now). Lets just add a URLField to this model and one or the other (but not both) are required. We should think through that any URLs may have query string information appended to them, but I think we can worry about how to implement that later.

ischneider pushed a commit to ischneider/geonode that referenced this pull request Jul 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants