-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra flags for mysqld_exporter #629
base: main
Are you sure you want to change the base?
Support extra flags for mysqld_exporter #629
Conversation
bc29ff4
to
eac877c
Compare
e395f17
to
3f26d14
Compare
Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
It's possible that mysqldExporter.extraFlags are provided while mysqldExporter.resources are not. Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
Similar to checkPodStatusWithTimeout(), but uses selectors and checks the pod spec for matches. Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
Signed-off-by: Sergey Stankevich <stankevich@users.noreply.github.com>
3f26d14
to
4f78932
Compare
Thanks for the helpful pointers, @frouioui! I regenerated the The upgrade test is passing locally, but is failing in CI. Unfortunately, I'm not able to see the reason. I noticed that the post-upgrade |
@@ -251,6 +260,7 @@ checkSemiSyncSetup | |||
verifyDurabilityPolicy "commerce" "semi_sync" | |||
upgradeToLatest | |||
verifyVtGateVersion "22.0.0" | |||
verifyResourceSpec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: once the next release (v2.15.0
) is out, we should do that check before and after we upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for working on that ❤️
These tests are unfortunately pretty flaky indeed 😢 Hopefully we get some time to work on this. |
fdc713e
to
4f78932
Compare
…n-mysqld-exporter
Merged |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Still flaky/failing. I added a retry mechanism to the verify vtgate version function. Hopefully that should help. |
…n-mysqld-exporter
Adds a new
mysqldExporter.extraFlags
property that can be used to pass custom flags to mysqld_exporter to enable/configure additional collectors. Also, makes it possible to override thecollect.info_schema.tables.databases
value if needed. The default behaviour and collector flags remain unchanged.This PR largely follows existing code conventions in the operator. I added a new
FormatArgsConvertBoolean()
method to Flags to support mysqld_exporter's flag format. Added the tests for it and for the existingFormatArgs()
andMerge()
methods.Closes #470.