Skip to content

Commit

Permalink
vitessio#13175 is fixed, therefore re-instating on-deman heartbeats
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
  • Loading branch information
shlomi-noach committed Jun 1, 2023
1 parent a02478d commit 11ca17a
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions go/test/endtoend/vreplication/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -412,13 +412,7 @@ func (vc *VitessCluster) AddTablet(t testing.TB, cell *Cell, keyspace *Keyspace,

options := []string{
"--queryserver-config-schema-reload-time", "5",
// Replace constant heartbeats (--heartbeat_enable) with the
// on-demand ones (--heartbeat_on_demand_duration=5s) once
// https://github.com/vitessio/vitess/issues/13175 is fixed.
// This is because rdonly or replica tablets will almost always
// be chosen as the vstreamers.
// "--heartbeat_on_demand_duration", "5s",
"--heartbeat_enable",
"--heartbeat_on_demand_duration", "5s",
"--heartbeat_interval", "250ms",
} // FIXME: for multi-cell initial schema doesn't seem to load without "--queryserver-config-schema-reload-time"
options = append(options, extraVTTabletArgs...)
Expand Down

0 comments on commit 11ca17a

Please sign in to comment.