Skip to content

Commit

Permalink
Use constant heartbeats in vrepl e2e tests
Browse files Browse the repository at this point in the history
Until vitessio#13175 is
fixed.

Signed-off-by: Matt Lord <mattalord@gmail.com>
  • Loading branch information
mattlord committed May 31, 2023
1 parent e03df30 commit 70570a5
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion go/test/endtoend/vreplication/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,13 @@ func (vc *VitessCluster) AddTablet(t testing.TB, cell *Cell, keyspace *Keyspace,

options := []string{
"--queryserver-config-schema-reload-time", "5",
"--heartbeat_on_demand_duration", "5s",
// Replace constant heartbeats (--heartbeat_enable) with the
// on-demand ones (--heartbeat_on_demand_duration=5s) once
// https://github.com/vitessio/vitess/issues/13175 is fixed.
// This is because rdonly or replica tablets will almost always
// be chosen as the vstreamers.
// "--heartbeat_on_demand_duration", "5s",
"--heartbeat_enable",
"--heartbeat_interval", "250ms",
} // FIXME: for multi-cell initial schema doesn't seem to load without "--queryserver-config-schema-reload-time"
options = append(options, extraVTTabletArgs...)
Expand Down

0 comments on commit 70570a5

Please sign in to comment.