Skip to content

Commit

Permalink
Address review comment: needed to reverse the bools passed because th…
Browse files Browse the repository at this point in the history
…e variable name had changed from positive to negative intent ...

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
  • Loading branch information
rohit-nayak-ps committed Dec 12, 2024
1 parent 5ed2dcb commit a974850
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion go/vt/vtgate/vindexes/vschema.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ func BuildVSchema(source *vschemapb.SrvVSchema, parser *sqlparser.Parser) (vsche
buildKeyspaces(source, vschema, parser)
// buildGlobalTables before buildReferences so that buildReferences can
// resolve sources which reference global tables.
BuildGlobalTables(source, vschema, true)
BuildGlobalTables(source, vschema, false)
buildReferences(source, vschema)
buildRoutingRule(source, vschema, parser)
buildShardRoutingRule(source, vschema)
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/vschema_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func (vm *VSchemaManager) buildAndEnhanceVSchema(v *vschemapb.SrvVSchema) *vinde
// Add tables from schema tracking into globally routable tables, if they are not already present.
// We need to skip if already present, to handle the case where MoveTables has switched traffic
// and removed the source vschema but not from the source database because user asked to --keep-data
vindexes.BuildGlobalTables(v, vschema, false)
vindexes.BuildGlobalTables(v, vschema, true)
}
return vschema
}
Expand Down

0 comments on commit a974850

Please sign in to comment.