Refactor and Enhance Compatibility of redmine_issue_field_visibility Plugin #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2023 21:03
Converted all methods to use `alias_method` * Removal of `setup` method * Renamed `History.txt` to `CHANGELOG.md`
…ived a Project instance. We need to ensure that this method is only invoked with Issue objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've overhauled the redmine_issue_field_visibility plugin to utilize alias_method for improved stability - SystemStackError (stack level too deep), especially when integrated with multiple other plugins. In the process, I've also refactored parts of the code to enhance compliance with coding standards.
However, a note of caution: while most of the changes have been tested, one test did not pass. Despite the test failure, the functionality seemed to operate correctly during manual tests. It would be beneficial for this to be further verified by the team to ensure robustness.
Your feedback and thorough review would be highly appreciated.