Merge pull request #358 from anilkumarthakur60/master

Migration Class Refactor and Column Existence Check
plank · Sep 2, 2024 · a2c3308 · a2c3308
2 parents 2b3d1be + 8a3ccc1
commit a2c3308
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 26 deletions.
diff --git a/migrations/2016_06_27_000000_create_mediable_tables.php b/migrations/2016_06_27_000000_create_mediable_tables.php
@@ -5,14 +5,13 @@
 use Illuminate\Support\Facades\Schema;
 use Plank\Mediable\Media;
 
-class CreateMediableTables extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      *
      * @return void
      */
-    public function up()
+    public function up(): void
     {
         if (!Schema::hasTable('media')) {
             Schema::create(
@@ -52,7 +51,7 @@ function (Blueprint $table) {
      *
      * @return void
      */
-    public function down()
+    public function down(): void
     {
         Schema::dropIfExists('mediables');
         Schema::dropIfExists('media');
@@ -65,4 +64,4 @@ public function getConnection()
     {
         return config('mediable.connection_name', parent::getConnection());
     }
-}
+};
diff --git a/migrations/2020_10_12_000000_add_variants_to_media.php b/migrations/2020_10_12_000000_add_variants_to_media.php
@@ -6,21 +6,27 @@
 use Illuminate\Support\Facades\Schema;
 use Plank\Mediable\Media;
 
-class AddVariantsToMedia extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      *
      * @return void
      */
-    public function up()
+    public function up(): void
     {
-        Schema::table(
+        Schema::whenTableDoesntHaveColumn(
             'media',
+            'variant_name',
             function (Blueprint $table) {
                 $table->string('variant_name', 255)
                     ->after('size')
                     ->nullable();
+            }
+        );
+        Schema::whenTableDoesntHaveColumn(
+            'media',
+            'original_media_id',
+            function (Blueprint $table) {
                 $table->foreignIdFor(Media::class, 'original_media_id')
                     ->nullable()
                     ->after('variant_name')
@@ -35,19 +41,21 @@ function (Blueprint $table) {
      *
      * @return void
      */
-    public function down()
+    public function down(): void
     {
-        Schema::table(
+        Schema::whenTableHasColumn(
             'media',
+            'original_media_id',
             function (Blueprint $table) {
                 if (DB::getDriverName() !== 'sqlite') {
                     $table->dropForeign('original_media_id');
                 }
                 $table->dropColumn('original_media_id');
             }
         );
-        Schema::table(
+        Schema::whenTableHasColumn(
             'media',
+            'variant_name',
             function (Blueprint $table) {
                 $table->dropColumn('variant_name');
             }
@@ -61,4 +69,4 @@ public function getConnection()
     {
         return config('mediable.connection_name', parent::getConnection());
     }
-}
+};
diff --git a/migrations/2024_03_30_000000_add_alt_to_media.php b/migrations/2024_03_30_000000_add_alt_to_media.php
@@ -6,19 +6,19 @@
 use Illuminate\Support\Facades\Schema;
 use Plank\Mediable\Media;
 
-class AddAltToMedia extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      *
      * @return void
      */
-    public function up()
+    public function up():void
     {
-        Schema::table(
+        Schema::whenTableDoesntHaveColumn(
             'media',
+            'alt',
             function (Blueprint $table) {
-                $table->text('alt');
+                $table->text('alt')->nullable();
             }
         );
     }
@@ -28,10 +28,11 @@ function (Blueprint $table) {
      *
      * @return void
      */
-    public function down()
+    public function down():void
     {
-        Schema::table(
+        Schema::whenTableHasColumn(
             'media',
+            'alt',
             function (Blueprint $table) {
                 $table->dropColumn('alt');
             }
@@ -45,4 +46,4 @@ public function getConnection()
     {
         return config('mediable.connection_name', parent::getConnection());
     }
-}
+};
diff --git a/tests/migrations/2016_06_27_000001_create_mediable_test_tables.php b/tests/migrations/2016_06_27_000001_create_mediable_test_tables.php
@@ -7,14 +7,13 @@
 /**
  * Create table for mock mediable model
  */
-class CreateMediableTestTables extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      *
      * @return void
      */
-    public function up()
+    public function up(): void
     {
         Schema::create('sample_mediables', function (Blueprint $table) {
             $table->increments('id');
@@ -47,7 +46,7 @@ public function up()
      *
      * @return void
      */
-    public function down()
+    public function down(): void
     {
         Schema::connection($this->getConnectionName())->table('media', function (Blueprint $table) {
             $table->dropColumn('deleted_at');
@@ -65,4 +64,4 @@ public function getConnectionName(): ?string
     {
         return config('mediable.connection_name', $this->getConnection());
     }
-}
+};